Update order-properties to use sort-package-json#55
Merged
JoshuaKGoldberg merged 2 commits intoOct 17, 2023
Merged
Conversation
JoshuaKGoldberg
approved these changes
Oct 17, 2023
JoshuaKGoldberg
left a comment
Collaborator
There was a problem hiding this comment.
D'oh! I don't know how this slipped by me - sorry for taking two weeks @kendallgassner!
Changes look great. Just a few small nits I can take care of. Will release soon. Thanks! 🚀
Collaborator
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

closes: #31
What
order-propertiessorting algorithm to use sort-package-json.optionsfrom anArray<string>tolegacyCallouts
Option:
order: Array<string>Previously, any property that was not provided in the
order: Array<string>collection was ignored by the sort algorithm. Now that we are usingsort-package-json, a property that is not provided in theorder: Array<string>will be sorted by thedefaultSortOrderprovided by the library.Sort-package-json version
the latest version of sort-package-json is an esm module so I opted to use an earlier version to avoid heavy refactorign. This package can be bumped when #33 is merged.